Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and updates for CubePilot PPPGW #26512

Merged
merged 11 commits into from
Jun 27, 2024
Merged

Fixes and updates for CubePilot PPPGW #26512

merged 11 commits into from
Jun 27, 2024

Conversation

bugobliterator
Copy link
Member

  • adds webui for vehicle build.
  • adds PPP support to CubeOrangePlus
  • changes for updated CubePilot PPPGW module
  • fix broken webui trying to remove already closed socket

@tridge tridge force-pushed the pr-cubepilot-pppgw branch from 259a7c4 to 95dddd6 Compare March 17, 2024 05:47
@bugobliterator bugobliterator force-pushed the pr-cubepilot-pppgw branch 3 times, most recently from e016957 to 2111385 Compare June 2, 2024 06:15
@bugobliterator bugobliterator requested a review from tridge June 11, 2024 02:25
peterbarker
peterbarker reviewed Jun 19, 2024
View reviewed changes
libraries/AP_HAL/utility/Socket.cpp Outdated
@@ -327,8 +347,12 @@ ssize_t SOCKET_CLASS_NAME::recv(void *buf, size_t size, uint32_t timeout_ms)
socklen_t len = sizeof(struct sockaddr_in);
int fin = get_read_fd();
ssize_t ret;
ret = CALL_PREFIX(recvfrom)(fin, buf, size, MSG_DONTWAIT, (sockaddr *)&last_in_addr[0], &len);
if (ret <= 0) {
uint32_t in_addr[4] = {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uint32_t in_addr[4] = {};
uint32_t in_addr[4] {};

@tridge tridge force-pushed the pr-cubepilot-pppgw branch from aa9f5de to cfbbbf4 Compare June 21, 2024 23:03
@tridge
Copy link
Contributor

tridge commented Jun 21, 2024

@bugobliterator I have rebased and fixed conflicts

@peterbarker peterbarker merged commit 10c6020 into ArduPilot:master Jun 27, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker left review comments

@tridge tridge tridge approved these changes

Assignees
No one assigned
Labels
MergeOnCIPass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugobliterator @tridge @peterbarker